vignesh-manel commented on PR #28629: URL: https://github.com/apache/camel/pull/28629#issuecomment-6476852755
@oscerd thanks for the review, and for running the JGit case. All four points are done: 1. **Upgrade-guide conflict:** main is merged in (bbecc69; a normal merge, no rebase, since we don't force-push this branch). The camel-git section now sits after `=== camel-github2 - the commit consumer routes the commits beyond the newest 100` instead of at the end of the file. 2. **Tag with the branch name:** confirmed and fixed in b1f89cd. The existing branch is checked out by `refs/heads/<branchName>`, and the create path keeps the short name, as you noted. I left the same ambiguity on the create path and on the other operations that switch branch for a follow-up, as you suggest. 3. **`checkoutExistingBranchTest`:** now moves `master` one commit past the branch, tags that commit with the branch name, and checks that HEAD is the branch at its own commit. Before the fix it failed with `expected: <testBranch> but was: <31c83b3a…>` (detached HEAD at the tag), and it passes after. 4. **Upgrade guide:** says that `commit` and `commitAll` replace a `CamelGitCommitId` already on the message (a24980b). Locally, `GitProducerTest` (38) and `GitConsumerCommitTest` (2) pass, and sourcecheck is clean. The PR description is updated. CI is running on a24980b. _Claude Code on behalf of vignesh-manel_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
