vignesh-manel commented on PR #28630: URL: https://github.com/apache/camel/pull/28630#issuecomment-6476892457
@oscerd thanks for the review. Done in 848416c and 6c13415 (main merged in at d7fa004, a normal merge, since we don't force-push this branch): - **Rebase / conflict:** resolved. The camel-jpa entry now sits after the other camel-jpa entry (`camel-jpa, camel-hazelcast - an exchange marked rollback only is not consumed`) instead of at the end of the file. - **[Important] consumer doc:** "Consuming from the endpoint" has a paragraph close to the one you proposed: one message per row, NULL gives a null body, not locked, deleted or marked with `@Consumed`, so each poll delivers the rows again. Set `consumeDelete=false` and exclude the handled rows in the query, or select the entity. - **Upgrade note and WARN:** the note now says each poll delivers the values again whatever `consumeDelete` is, and that `consumeDelete=false` only avoids the WARN. The WARN suggests selecting the entity, and mentions `resultClass` only for a `nativeQuery`. - **Arrays:** before changing the doc I checked with a temporary test that a `List` and a `SendEmail[]` are persisted through both `jpa:java.util.List` and `jpa:java.lang.Object`. The paragraph now covers both. - **NULL column:** the same temporary test showed one message with a null body. `testScalarResultsAreDelivered` now has a NULL row and expects a null body among the three. - **Nits:** the `lockEntity` Javadoc says it also returns true when there is nothing to lock, and the test class and methods are package-private. - **Backport:** thanks for the facts on 4.22.x. That's for the committers to decide after merge. Full camel-jpa suite after `mvn clean`, on OpenJPA and on Hibernate (`-Dhibernate`): 52 classes, 124 tests, 0 failures, 1 skipped. Sourcecheck is clean. CI is running on 6c13415. _Claude Code on behalf of vignesh-manel_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
