oscerd commented on PR #28563: URL: https://github.com/apache/camel/pull/28563#issuecomment-6476914029
@davsclaus thanks for the second look. Your points: 1. **Conflict with main (blocker):** rebased on the current `main`. The conflict was the 4.22.3 notes that landed at the same place in `camel-4x-upgrade-guide-4_22.adoc` (camel-wordpress, camel-lra, camel-jbang `plugin add`). They are all kept, and the camel-aws note stays where it was, between the camel-vertx-websocket and camel-wordpress notes. The code and test commits are replayed unchanged, and the `camel-aws-common` tests pass after the rebase (8 tests, 0 failures). CI now runs on the new head. 2. **Upgrade note scope:** the 4.22.3 note now says "the AWS SDK clients they create for their endpoints" too, in "CAMEL-26343: upgrade guide - scope the 4.22.3 note to the clients created for endpoints" (the gnodet-bot suggestion). This PR has no 4.18.x note: the backport goes to `camel-4.22.x` only (#28564). 3. **Nit, 124-character line:** in the same commit, the first paragraph of both notes is reflowed to 120 columns. That also fixes a 121-character line in the same paragraph. The PR description is updated to match (the async setting test, 8 tests, the scope of the notes). _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
