oscerd commented on PR #28623: URL: https://github.com/apache/camel/pull/28623#issuecomment-6476994569
@davsclaus thanks for the review. Your points: 1. **Conflict with main:** rebased on the current `main`. The conflict was the CAMEL-26344 `camel plugin add` note added at the same place in `camel-4x-upgrade-guide-4_22.adoc`. Both sections are kept: the camel-oauth note stays where it was, after the camel-lra note, and the camel-jbang note follows it. The 4.18 guide merged without a conflict. 2. **"can override" understates it:** agreed. On `main`, `OAuthSessionStore.rotateSession` returns the session unchanged and its `@implNote` says implementors MUST override it, and `OAuthCodeFlowCallback` rotates the session through it. The backports #28621 (`camel-4.22.x`) and #28616 (`camel-4.18.x`) port the same default and `@implNote`. "CAMEL-26319: upgrade guide - a custom OAuthSessionStore must override rotateSession" uses your sentence in the 4.22.3 and 4.18.6 notes, and in the 4.24 note in `camel-4x-upgrade-guide-4_24.adoc` too. The PR description now mentions the 4.24 note. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
