allthingssecurity commented on PR #28637: URL: https://github.com/apache/camel/pull/28637#issuecomment-6486369284
@gnodet thanks for the review. Both points are addressed in d1af39ff2c0b (one new commit on top), see the inline replies. - The race: the consumer no longer relies on cancelling the start. The processor, the attempts and `doStop` hand over under a lock, with a generation, and a processor whose start ends after the stop is stopped by its attempt. A failed start that had already started the workers of some leases is now stopped too; before, those workers kept running next to the next processor. - Tests: new `CosmosDbConsumerStopWhileStartingTest`, 6 tests with a processor that behaves as the azure-cosmos 4.75 one. 4 of them fail on the previous head. The class passed 21 runs in a row in one JVM (126 tests, 0 failures). camel-azure-cosmosdb unit tests: 57 run, 0 failures, 22 ITs skipped (no credentials). - Backports: I cannot set labels. If you want them, please add `port/camel-4.22.x` and `port/camel-4.18.x`. Both commits apply cleanly to camel-4.22.x and camel-4.18.x (checked with `git merge-tree`). On camel-4.18.x the two test classes need `org.apache.camel.test.junit5.CamelTestSupport` instead of `junit6`, as the module still uses junit5 there. I updated the description to match. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
