allthingssecurity commented on PR #28593: URL: https://github.com/apache/camel/pull/28593#issuecomment-6464771897
@davsclaus thanks, done in b11b74e6b743 (one new commit on top). **Blockers** 1. Mixed record types: the upgrade guide now shows the H/D/T example (`H,d`, `D,s,q` and `T,n` before; `H,d`, `D,,s,q` and `T,,,,n` now). It also gives the way back: convert the rows to `List`, or set a custom `marshallerFactory` (`marshallerFactoryRef` in XML/YAML). The data format page says the same. New test `rowsOfDifferentRecordTypesGetTheColumnsOfAllRows` pins the new output, and `listRowsOfDifferentRecordTypesKeepTheirOwnFields` covers the `List` way out. 2. Output size: I documented it rather than adding a cap. A cap would need a new option and a choice of what to do when it's reached. The data format page and the guide say that every row has all the columns seen so far, so rows that each have their own keys give about N²/2 fields. For such data they suggest `List` rows, or a `header` with only the columns you need. **Non-blocking** 1. A null column is looked up through the entries, not with `get(null)`. I also catch the `ClassCastException` that a `TreeMap` row throws for a key of another type from an earlier row; that row then gets no value. Both have a test, and both tests fail on the previous head. 2. `@since 4.24` added. camel-csv: 102 run, 0 failures. I updated the description to match. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
