apupier opened a new pull request, #28627: URL: https://github.com/apache/camel/pull/28627
The test sent 2 messages and immediately simulated a connection failure without waiting for the batch consumer to receive them. With AUTO_ACKNOWLEDGE, BatchConsumerWorker dispatches already-acknowledged buffered messages on a connection failure (they cannot be redelivered). If only 1 of the 2 messages had been received at that point, a batch of 1 was dispatched, failing with "expected: <2> but was: <1>". Wait until the tracked consumer has received both messages before triggering the failure, as BatchConsumerStopStartTest already does. How it was reproduced: - Running the original test 10 times in a row, and 5 times with all 22 cores saturated by busy loops, did not fail: the race window is tiny locally. - Temporarily adding Thread.sleep(300) in BatchConsumerWorker.run() right after buffer.add(msg) (not committed) widened the window and the original test then failed deterministically with "expected: <2> but was: <1>" at BatchConsumerReconnectTest:89. - With the same temporary sleep, the fixed test passed 3 out of 3 runs. Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
