davsclaus commented on PR #28575: URL: https://github.com/apache/camel/pull/28575#issuecomment-6467034797
Thanks for the review, @oscerd. - **The 4-arg constructor:** it is public API since 4.23.0, so dropping it would break callers outside Camel. I will mark it `@Deprecated` (the javadoc already says `nodeTextPadding` is not used), and move the three callers in camel-jbang (`CamelRouteDiagramAction`, `CamelHistoryAction`, `ListError`) to the 3-arg one. - **The stack:** yes, the merge order is #28575, then #28585, then #28586, and each PR is retargeted to `main` before its base branch is deleted. #28586 merges the latest #28585 now, so it is no longer conflicting. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
