davsclaus commented on PR #28743: URL: https://github.com/apache/camel/pull/28743#issuecomment-6535093535
_Claude Code on behalf of davsclaus_ Thanks for the review, both points are done in e6b172a440ba: 1. `KameletMainIntegration.stop()` logs a failure to stop at debug level (`Failed to stop the integration: ...`, with the exception), still best effort, as the integration may already be stopping. 2. `YamlLoadFailureReport.ReloadFailureNotifier` is removed: `camel run` reports a reload failure through `RunContext.withReloadFailureListener(YamlLoadFailureReport::logIfYamlLoadFailure)` now, with the notifier of the engine (`JBangRunnerTest.aRouteFileThatFailsToReloadIsReported` tests that one). Its test in camel-jbang-core became `theReportIsForTheRouteFileThatFailedToReload`: the report for the file that failed to reload. The branch also has main merged in (CAMEL-26409 and CAMEL-26403). Locally: camel-jbang-export 230 tests pass; camel-jbang-core 2422 + 287, with only the failures that also fail on main locally (`EvalSimpleTest` and 9 AI tests about the elvis operator of Simple); the golden test unchanged; the plugins and the launcher compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
