gnodet-bot commented on code in PR #28764: URL: https://github.com/apache/camel/pull/28764#discussion_r4430940963
########## dsl/camel-jbang/camel-jbang-core/src/main/resources/log4j2-off.properties: ########## @@ -0,0 +1,36 @@ +## --------------------------------------------------------------------------- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --------------------------------------------------------------------------- + +# The logging of a command that turned the logging off (see RuntimeUtil.configureLog), which log4j configures itself +# with when something first logs: the one of log4j2-no-color.properties, with the logging off. Review Comment: Confusing phrasing — circular reference to itself. Suggested replacement: ```suggestion # A copy of log4j2-no-color.properties with rootLogger.level=OFF, used for deferred log4j # initialization: when a command sets level=off, log4j is not configured immediately; it # self-configures with this file only when something first logs (see RuntimeUtil.configureLog). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
