knockknock10 commented on PR #6922:
URL: https://github.com/apache/camel-k/pull/6922#issuecomment-6542131750

   Thanks for the review, @squakez.
   
   I've removed `queueType` since selecting the `ibmmq` metadata already 
identifies the scaler.
   
   I also checked whether we could derive `host` from the JMS connection 
properties. Those properties describe the MQ connection, but don't necessarily 
give us the mqweb Admin REST endpoint KEDA needs. So I've kept it explicit and 
added a test for this case.
   
   I've updated the docs and tests as well.
   
   I'll wait for the related KEDA design and shared testing changes before 
making further changes here.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to