allthingssecurity commented on PR #28785:
URL: https://github.com/apache/camel/pull/28785#issuecomment-6555791085
Thanks for the review. Fixes are in 9dbeb91.
1. Both WARNs now name the processor (`outputAsync`). The late-callback one
uses your wording. The other one, where the exception comes after a queued
callback has already continued the exchange, now reads "Error executing the
redelivery of exchangeId: {} by its processor {} due to {}". In the test logs
both name the test's processor, e.g. `RedeliveryProcessorThrowsTest$6@...`. No
test asserts the text. I added the possible second side effect and the dropped
late result to the behaviour-change paragraph in the description.
2. The follow-up JIRAs are drafted and will be linked from CAMEL-26430
shortly. One covers `SimpleTask.handleFirst()` (the default error handler
without redelivery, CAMEL-26301's path). The other covers the first delivery in
`run()`: a throw there skips the DLC and `onException`, and a callback handed
to another thread before the throw can continue the exchange twice. That second
one says redelivery now loops back, so the first delivery should be made
consistent with it. The description says the same.
3. `doRedeliver(continued, exchangeId)` now takes the id from `redeliver()`,
and the second local is gone.
Tests: `RedeliveryProcessorThrowsTest` and
`RedeliveryProcessorThrowsPooledTest` each 20 times in one JVM (520 tests),
plus the redelivery, dead letter channel, error handler and onException tests
of camel-core (577 tests). 0 failures.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
