allthingssecurity commented on PR #28782:
URL: https://github.com/apache/camel/pull/28782#issuecomment-6555811145
Thanks @davsclaus, all four points are in 5c5cd935ff04.
1. `install` and `alsoRewrite` now call `ensureAgent()` before they touch
`PREFIXES`/`ALSO`, as in your snippet, and `retransform` assumes the agent is
set. New `DstMissingAgentTest`: it starts a JVM without `-javaagent` and calls
`install` twice and `alsoRewrite` twice for the same package and class. All
four calls fail with the message and nothing gets registered. On the previous
head, the second calls printed "no error" and the package stayed registered.
20/20 runs pass.
2. Setup now has a plain surefire snippet for projects outside the Camel
build: the `dependency:properties` execution,
`"-javaagent:${net.bytebuddy:byte-buddy-agent:jar}" @{argLine}`, and the empty
`<argLine/>` property with a note on why it is there. The Camel
`camel.surefire.fork.additional-vmargs` wiring follows it.
3. Step 2 of the guide starts with "Add the agent to the module's pom first,
see Setup" (`<<_setup,Setup>>`). The checklist has a new first item for the
same thing.
4. Quoting is applied to the 5 component poms, the camel-test-dst `argLine`
and the docs. I checked it on macOS only, with the agent jar copied to a
directory with a space and passed via
`-Dnet.bytebuddy:byte-buddy-agent:jar=...`. Unquoted, the fork does not start
("Error opening zip file ... /agent"). Quoted, the camel-test-dst tests and
`SlackSuspendDstTest` pass. I did not try it on Windows.
The 6 DST classes of the 5 worlds pass with their default seeds, and
camel-test-dst passes 59/0. The branch still merges cleanly with #28787 and
main.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
