gnodet-bot commented on code in PR #28885:
URL: https://github.com/apache/camel/pull/28885#discussion_r4443849240
##########
.github/workflows/camel-launcher-native-exe.yml:
##########
@@ -224,10 +224,13 @@ jobs:
# Plain mvn: once -am is gone this reactor is only a few modules, so
the mvnd
# daemon brings no parallelism benefit and adds a cold-start failure
mode.
# -P apache-snapshots is required here so the upstream modules resolve.
+ #
+ # With the tests: this is the only build with the native exe files,
which the tests that need
+ # -Dcamel.exe.build=true check (PackagePlanTest, and the *IT of the
distributions in verify).
run: |
Review Comment:
`PackagePlanTest` does not require `-Dcamel.exe.build=true`. Looking at
`PackagePlanTest.java`, the class has no `@EnabledIfSystemProperty(named =
"camel.exe.build", ...)` guard — the only reference to that property in the
file is in a Javadoc comment on a method that documents
`CamelLauncherNativeExeIT`, not `PackagePlanTest` itself. `PackagePlanTest` is
a plain surefire unit test that runs regardless of that property.
Only the `*IT` integration tests (e.g. `CamelLauncherNativeExeIT`) need
`-Dcamel.exe.build=true` to activate.
Suggested fix:
```suggestion
# With the tests: this is the only build with the native exe files,
which the
# *IT integration tests of the distributions need (they are disabled
without -Dcamel.exe.build=true).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
