Jinal-Sarvaiya commented on PR #149: URL: https://github.com/apache/camel-kit/pull/149#issuecomment-6581796704
### Review Finding Fixes — 2026-11-02 **Finding 1: Worker can invoke inherited MCP tools — Fixed** (`camel-ship-worker.md`) Added `mcp: deny` to the permission block and explicit "Do not call MCP tools" instruction in the worker body, matching the pattern used by Claude, Bob2, and Qwen workers. The `"*": deny` permission only blocks built-in tools; MCP tools inherited from the parent OpenCode session require separate denial. `ShippedAssetStructureTest` now asserts both `mcp: deny` and `call MCP tools` in the worker. **Finding 2: Full OpenCode Ship acceptance — PASS** Live acceptance on Linux aarch64 (Docker `eclipse-temurin:21-jdk-jammy`), OpenCode v2.2.5, EnMaaS gateway (`api.enmaas.devshift.net`), Flint 40B Free model: | Test | Result | |------|--------| | Smoke test (simple prompt) | PASS — model responded correctly | | DISCOVERY stage via `camel-ship-worker` agent | PASS — returned valid schema v2 JSON | | MCP denial verification | PASS — worker reports "no MCP tools are exposed to me here, and the permission context blocks MCP server access" | Worker correctly: reads `context-authority.md`, returns structured JSON, uses only allowed tools (`read`, `glob`, `grep`), and cannot access MCP servers. **Linux unit test results (Docker, Java 21.0.12.1):** | Test Class | Result | |-----------|--------| | OpenCodeNativeWorkerTest | 24/24 pass | | OpenCodeGeneratorTest | 37/37 pass | | ShippedAssetStructureTest | 9/9 pass (includes new MCP assertions) | | ShipCommandTest | 70/71 pass (1 pre-existing root permission failure) | | ShipRunTest | 12/12 pass | | Sourcecheck | pass | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
