davsclaus commented on code in PR #28905:
URL: https://github.com/apache/camel/pull/28905#discussion_r4445659155
##########
components/camel-dfdl/src/main/java/org/apache/camel/dataformat/dfdl/DfdlDataFormat.java:
##########
@@ -71,7 +71,7 @@ public void marshal(Exchange exchange, Object graph,
OutputStream stream) throws
W3CDOMInfosetInputter inputter = new
W3CDOMInfosetInputter(xmlDocument);
UnparseResult result = this.daffodilProcessor.unparse(inputter,
Channels.newChannel(stream));
if (result.isError()) {
- exchange.setException(new DfdlUnparseException(result));
+ throw new DfdlUnparseException(result);
}
Review Comment:
Thanks. `unmarshal` now throws the `DfdlParseException` too, the same as
`marshal`, in e196b174cbe0. Note that `testParseErrorHandledKeepsBody` passed
before this change as well (CI was green), but throwing is the consistent way.
_Claude Code on behalf of Claus Ibsen (davsclaus)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]