allthingssecurity commented on PR #28811:
URL: https://github.com/apache/camel/pull/28811#issuecomment-6571525119

   Thanks for the review. Pushed in 2b63d94 (main merged in, no rebase):
   
   - **design/chaos.adoc:** main is merged into the branch, and the sentence 
from #28788 saying netty-http `status` is not supported yet is gone. The 
component doc and its catalog copy did not need a change.
   - **`location()`:** the redirect location is now only given for `http`, 
`https` and `netty-http`. undertow and vertx-http get none. New test: 
`undertowGivesNoRedirectLocation`.
   - **`getDefaultName()` in `httpFailure`:** agreed. I'll keep it with the 
follow-up about components added under a name of their own, so 
`ChaosConsumers`, `status=` and the exception choice all switch to the default 
name together.
   - **The `ChaosRuleParserTest` line shared with #28812:** whichever merges 
second keeps both lines.
   
   Tests: camel-chaos 273 tests pass after the merge, and `ChaosHttpFaultTest` 
passed 20 runs, each in its own JVM.
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to