apupier opened a new pull request, #28864:
URL: https://github.com/apache/camel/pull/28864

   The test testSendLotsOfMessagesButOnly3GetThroughWithin2Seconds expected 3 
messages, but the route throttles 3 per group, with the correlation expression 
being the value of the "key" header ("1" or "2"). There are therefore 2 groups 
with 3 permits each, and up to 6 of the 9 messages can pass immediately.
   
   The test only passed when the main thread checked the mock right after the 
3rd message arrived, and before the 4th to 6th reached it: 
MockEndpoint.assertIsSatisfied() waits on a latch for the expected count, then 
compares it to the received counter without waiting for further messages. When 
the seda consumer thread was faster, the count was 4, 5 or 6, which are the 
failures observed on CI. The 1000ms time period could also lapse during the 
test and let the remaining messages through in a second window.
   
   The test now expects the 6 first messages in order, and uses an assert 
period to verify that no more messages get through afterwards. The time period 
of the route is raised to 5000ms so that held messages cannot be released 
during the assert period, even on a slow machine. The test is renamed to 
reflect the actual behavior.
   
   Co-authored-by: IBM Bob 2.2.1
   
   # Description
   
   <!--
   - Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   -->
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other 
small items do not require a JIRA issue. In this case your pull request should 
address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] 
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the 
appropriate JIRA issue.
   -->
   
   - [ ] I have run `mvn clean install -DskipTests` locally from root folder 
and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build 
auto-formats your code. This will also be verified as part of the checks and 
your PR may be rejected if if there are uncommited changes after running `mvn 
clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at 
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   # AI-assisted contributions
   
   - [ ] If this PR includes AI-generated code, commits have proper 
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR 
description identifies the AI tool used.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to