allthingssecurity commented on PR #28810: URL: https://github.com/apache/camel/pull/28810#issuecomment-6571525882
Thanks for the review. Pushed in 9668097: - **`sendThroughRemovedEndpoint`:** yes, that is intended for now, and the replacement is now logged at INFO. Keeping the old processor for the old endpoint is not a small change. The old `RecipientList` would have to stay started for as long as any stale endpoint or producer might still use it, but today it is stopped on replacement. So we'd need a count of the endpoints and exchanges still using it to know when to stop it. That is the same machinery as the `replacedProcessors` follow-up, so I'd do both there. Before this PR, the second URI failed outright. With it, the stale send routes with the new options instead of failing. - **`replacedProcessors` growth:** a follow-up JIRA will be filed so it is tracked. The PR description says so. - **`doShutdown`:** it now collects the recipient lists of the current and the replaced processors and calls `ServiceHelper.stopAndShutdownServices(...)`, so every one is tried. `super.doShutdown()` runs in a `finally`. `DynamicRouterComponentTest` checks that the other list is still stopped and shut down when one fails. Tests: `DynamicRouter*Test` (140) pass, and `DynamicRouterComponentTest` passed 20 runs, each in its own JVM. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
