oscerd commented on PR #28966:
URL: https://github.com/apache/camel/pull/28966#issuecomment-6588625456

   Thanks Claus.
   
   Field path: applied, as in #28964. `jsonErrorDetail` in `IAMProducer` now 
names the field from `JsonMappingException.getPath()`, with the field names and 
array indexes only, so a wrong type reads "wrong value for field enabled" with 
the line and column. It still does not use the message of Jackson, which quotes 
the value for a wrong type. The new tests 
`updateUserFailureNamesTheFieldWithAWrongValue` and 
`updateGroupFailureNamesTheFieldWithAWrongValue` check that the field is named 
and that the value is not in the message.
   
   Nit: right, and updateUser was not covered either: its existing tests only 
have `name` and `description`, which are the same in both namings. 
`IAMProducerJsonTest` now has `getGroupUsersGivesApiFieldNames` and 
`updateUserGivesApiFieldNames`, with fields such as `last_project_id`, 
`password_expires_at`, `pwd_status`, `xuser_id` and `is_domain_owner`, so the 
result names of every operation are tested. Both fail against the old Gson 
output.
   
   _Claude Code on behalf of Andrea Cosentino (oscerd)_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to