gnodet-bot commented on PR #29049: URL: https://github.com/apache/camel/pull/29049#issuecomment-6597100124
ℹ️ **Sibling component `camel-opentelemetry-metrics` has the same bug** — `CounterProducer.doProcess()` in `camel-opentelemetry-metrics` still falls through to `counter.add(1L, attributes)` when `increment`/`decrement` is configured but evaluates to a non-numeric value (current `main`). The commit message references CAMEL-26195 as the OTel companion, but that fix doesn't appear to be merged yet. Consider applying the same fix to avoid inconsistent behavior. ⚠️ Pre-fix test validation: ✅ `testIncrementFromBodyNotNumber` and `testIncrementOrDecrementFromHeaderMissing` correctly exercise the new `else if` branch — without the fix, `assertThrows(CamelExecutionException.class, ...)` would not throw and the tests would fail before the fix. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
