gnodet-bot commented on code in PR #29055: URL: https://github.com/apache/camel/pull/29055#discussion_r4459195448
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_18.adoc: ########## @@ -50,6 +50,13 @@ credentials. A deployment that counted on the inherited list as a restriction ha A consumer whose `requestUriPattern` is `/` now also uses its own keys, certificates and asynchronous MDN settings when another consumer created the shared server connection; before, it used the first consumer's. +=== camel-as2 - the asynchronous MDN allow-list matches the host and port + +The `asyncMdnAllowedHosts` option now matches the full authority — host and port — of the asynchronous MDN delivery +address. A bare-host entry (for example `partner.example`) now matches only the default port (80). Deployments that +receive asynchronous MDNs on a non-default port must add the port to their allow-list entry (for example +`partner.example:8443`). Review Comment: The upgrade guide documents the non-default port change but omits the IPv6 format change. **Before this PR:** an entry `::1` (unbracketed) matched any delivery to `[::1]` regardless of port — the old `isAllowedHost()` did a plain `equalsIgnoreCase(host)` comparison, and `normalizeHost()` strips brackets so `host = "::1"`. **After this PR:** `authorityMatches()` treats an unbracketed multi-colon entry as a bare-host matching the default port only (`entryPort = 80`). A delivery to `http://[::1]:1/` with entry `::1` now returns `entryPort (80) ≠ port (1)` → refused. Deployments with `asyncMdnAllowedHosts=::1` silently break. ```suggestion The `asyncMdnAllowedHosts` option now matches the full authority — host and port — of the asynchronous MDN delivery address. A bare-host entry (for example `partner.example`) now matches only the default port (80). Deployments that receive asynchronous MDNs on a non-default port must add the port to their allow-list entry (for example `partner.example:8443`). IPv6 entries must also be updated to use bracket notation: an unbracketed entry such as `::1` is now treated as a bare-host matching the default port (80) only; use `[::1]` for port 80 or `[::1]:port` for a specific port. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
