gitPratikSingh commented on PR #6926: URL: https://github.com/apache/camel-k/pull/6926#issuecomment-6615208090
Thanks for the review — you’re right, the issue asks to avoid the API check entirely, and my first version kept it. I’ve reworked it: the deletable types are now computed once at startup from the operator role files shipped with the operator, with a mapping table for the version and kind of each type, since role rules carry neither. Types with no API in the cluster, like an uninstalled Knative or KEDA CRD, are skipped instead of failing the run. I also removed the Disabling chapter from the doc and corrected the gc.enabled line — the trait is a platform trait and can’t be disabled. One thing I’d like your take on: for CRD types like KEDA ScaledObject I hardcoded the version in the mapping table, following the existing serving v1 / eventing v1 pattern. Is that the approach you’d prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
