oscerd opened a new pull request, #1853:
URL: https://github.com/apache/camel-kafka-connector/pull/1853

   Fixes #1282.
   
   ### Change
   
   In #1282, 
`camel.source.endpoint.onCompletionExceptionHandler=org.apache...CustomLoggingExceptionHandler`
 did not work, because the value needs `#class:` in front. We agreed in the 
thread to document this. This PR adds a "Referencing classes and beans in 
option values" section to `user-guide/basic-configuration.adoc`:
   
   - the reference forms from Camel's property binding: `#class:` (no-argument 
constructor, constructor arguments, factory methods), `#bean:` and `#type:`, 
with a pointer to `#property:` / `#autowired`;
   - where references work:
     - the `camel.source/sink.endpoint.*` options of the component-based 
connectors (file, https, jdbc, ...);
     - the query parameters of `camel.source/sink.url`;
     - `camel.component.<scheme>.<option>`, including nested properties;
     - `camel.beans.<name>`;
   - that Kamelet-based connectors don't read `camel.*.endpoint.*`, while 
`camel.component.*` and `camel.beans.*` still apply to them;
   - the example from the issue, in its wrong and right form, and the 
no-argument-constructor requirement;
   - a TLS example for `camel-https-kafka-connector` built from beans, 
mirroring `CamelSinkHTTPSITCase`;
   - quoting values that start with `#` in YAML (for example a Strimzi 
`KafkaConnector`), and a pointer to the Security Model.
   
   ### Verification
   
   Docs only, so no build is needed. Each statement was checked by running the 
real `CamelSourceTask` / `CamelSinkTask` on Camel 4.22.0, 11 scenarios in all:
   
   - A plain class name makes the task fail to start.
   - Constructor arguments and factory methods work.
   - `#type:` and nested `camel.beans` properties work.
   - A `#bean:` pointing to a missing bean makes the task fail to start.
   - The issue's `onCompletionExceptionHandler` and `exceptionHandler` options 
work with `#class:`.
   
   The page renders without warnings with Asciidoctor.js. Existing test 
coverage includes `PropertiesOrderTest`, `PropertiesNameFormatsTest`, 
`CamelSinkHTTPSITCase` and `CamelSinkJDBCNoDataSourceITCase`.
   
   _Claude Code on behalf of Andrea Cosentino_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to