Croway commented on issue #119:
URL:
https://github.com/apache/camel-upgrade-recipes/issues/119#issuecomment-6607135374
I reviewed what is still open here against `main` (4.24.0-SNAPSHOT), as
background for deciding whether to narrow or close it:
**Items 3–4 (version tests): mostly covered now.**
- 4.18 LTS: `CamelSpringBootBomVersionTest` (BOM property and
literal-version upgrades) and `CamelSpringBootParentVersionTest`
(camel-spring-boot parent) run `CamelSpringBoot418LTSMigrationRecipe` against
real POMs and expect 4.18.5.
- 4.22 LTS: the new `CamelSpringBoot422LtsVersionTest` in the 4.22 LTS PR
for #129 does the same for `CamelSpringBoot422LTSMigrationRecipe`, plus Spring
Boot 3.5 → 4.1.x.
- Latest: `aggregatesChangeTheBomProperties()` checks `latest.yaml`
structurally. A rewrite test on the latest aggregate is still missing on
purpose, because its target is `${project.version}`, which is an unresolvable
SNAPSHOT between releases (see the class Javadoc).
**Items 1–2 (suites re-running the SB tests against the aggregates): not
started, and not a drop-in like in core.** The core suites work because every
core test goes through `CamelTestUtil.recipe(...)` and `pomXmlSpec(...)`, which
switch to the aggregate and adjust the POM expectations when
`camelUpgradeRecipes-useRecipe` is set. The SB tests instead activate narrow
sub-recipes directly through `Environment.builder()...activateRecipes(...)`,
which is deliberate (see the `CamelSpringBoot423Test` Javadoc). So they would
have to be reworked first, and their POM expectations would change under an
aggregate because of its version bumps and the Java 17 step from the 4.19 chain.
The wiring those suites would catch is already guarded by
`LatestRecipeTest`, `TargetVersionOnlyInAggregatesTest`,
`aggregatesChangeTheBomProperties()` and the LTS version tests above. I'd
suggest either closing this, or narrowing it to items 1–2 if you think that
rework is worth it. Your call, since it's assigned to you.
_Claude Code on behalf of croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
