knockknock10 commented on PR #6927: URL: https://github.com/apache/camel-k/pull/6927#issuecomment-6636722436
I investigated the failing `advanced` job in [run #7384](https://github.com/apache/camel-k/actions/runs/41314003175/job/126640209658). The `common` job passed; only `TestMetrics/reconciliation_duration_metric` failed. The assertion at `e2e/advanced/operator_metrics_test.go:261` compared: - 12 `Reconciling Integration` log entries - 11 completed `Reconciled` histogram observations - 0 requeued and 0 errored observations I compared the test source on this PR branch with current `main`: it is byte-for-byte identical. The same test passed on current `main` in [the successful advanced job](https://github.com/apache/camel-k/actions/runs/41816964212/job/126530032602), with 12 log entries and 12 histogram observations. There is a plausible timing race in the existing test: the `Reconciling Integration` log is emitted when reconciliation starts, while `pkg/util/monitoring/controller.go` records the duration histogram only after the underlying `Reconcile` call returns. If one reconciliation is still in flight when the test scrapes metrics, the log count can be 12 while the histogram count is 11. The test currently compares those snapshots for exact equality. This failure is not caused by the changes in this PR: the advanced job builds via `make images` and runs `test-advanced`; it does not invoke the changed `images-push` or staging publishing targets, and neither the metrics test nor its instrumentation was changed here. I have not changed or skipped the unrelated test. I suggest keeping this PR scoped to the multi-architecture publishing fix. If you would like, I can take a separate follow-up to make the metrics test wait for reconciliation completion before comparing the log and histogram counts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
