allthingssecurity commented on PR #29118: URL: https://github.com/apache/camel/pull/29118#issuecomment-6625183347
Thanks @davsclaus, both done in ed9956eac7cf: - [Important] I took your `isAddress`: a real scheme (after an optional leading `//`) then `://`. `ChaosPatternsTest` now covers the `https` alias whose default name is `http` with a URL in the query (`https://inventory/stock?callback=http://elsewhere/done` stays as it is and is still matched by `endpoint=https:inventory*` and `component=https`), the renamed netty-http endpoint as `nh://http://...` and `nh:http://...`, and a renamed component whose URI is not an address. - [Suggestion] The javadoc of `endpointUri` and the chaos page (and its catalog copy) now say that undertow gives the address alone and netty-http `netty-http://http://host/path`. The full camel-chaos run also showed a second test broken on main by #28863: `ChaosNettyHttpFaultTest.statusRaisesTheNettyHttpOperationFailedException` checks that the url of the failure is the address, as camel-netty-http reports it, but chaos used `getEndpointBaseUri()`, now `netty-http://http://localhost:9/stock`. Chaos now takes the endpoint's `getAddressUri()` (by reflection, as camel-chaos does not depend on camel-netty-http). All 326 camel-chaos tests pass locally. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
