gnodet-bot commented on code in PR #29229:
URL: https://github.com/apache/camel/pull/29229#discussion_r4479636456
##########
test-infra/camel-test-infra-azure-storage-blob/src/main/java/org/apache/camel/test/infra/azure/storage/blob/services/AzureStorageBlobLocalContainerInfraService.java:
##########
@@ -20,15 +20,21 @@
import org.apache.camel.spi.annotations.InfraService;
import org.apache.camel.test.infra.azure.common.AzureConfigs;
import org.apache.camel.test.infra.azure.common.AzureCredentialsHolder;
+import org.apache.camel.test.infra.azure.common.AzureProperties;
import org.apache.camel.test.infra.azure.common.services.AzureInfraService;
import org.apache.camel.test.infra.azure.common.services.AzureServices;
import
org.apache.camel.test.infra.azure.common.services.AzureStorageInfraService;
+import org.apache.camel.test.infra.common.LocalPropertyResolver;
@InfraService(service = AzureInfraService.class,
description = "Local Azure services with Azurite",
serviceAlias = "azure", serviceImplementationAlias =
"storage-blob")
public class AzureStorageBlobLocalContainerInfraService extends
AzureStorageInfraService {
+ public AzureStorageBlobLocalContainerInfraService() {
+
super(LocalPropertyResolver.getProperty(AzureStorageInfraService.class,
AzureProperties.AZURE_STORAGE_BLOB_CONTAINER));
+ }
Review Comment:
Nit: this constructor is redundant — `AzureStorageInfraService()`'s no-arg
now resolves `AZURE_STORAGE_BLOB_CONTAINER` already (changed in this PR), so
removing this constructor would have the same effect. The queue subclass *does*
need its explicit constructor to read `AZURE_STORAGE_QUEUE_CONTAINER` instead
of the parent's default, but this one delegates to the same key.
Not blocking — having it explicit is arguably clearer about intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
