smongiar commented on PR #29250:
URL: https://github.com/apache/camel/pull/29250#issuecomment-6660788081
Thanks for the thorough reviews @Croway, @davsclaus, and the gnodet-bot
analysis. You're right — the original fix doesn't address the Windows polling
issue. I've rescoped the PR based on your feedback:
**Changes in the updated commit:**
1. **Replaced `remaining.replace('\\', '/')` with
`FileUtil.normalizePath(remaining)`** — this respects the per-OS rule,
consistent with how `GenericFileConfiguration.setDirectory()` already
normalizes.
2. **Rewrote tests with positive `assertEquals` assertions** — checking both
`getFile().getPath()` and `getConfiguration().getDirectory()` return the
expected normalized value. Added a `@DisabledOnOs(OS.WINDOWS)` test verifying
POSIX backslash normalization on non-Windows.
3. **Added upgrade-guide entry** in `camel-4x-upgrade-guide-4_24.adoc`
describing the behavioral change on Linux/macOS.
4. **Retitled PR and commit** to reflect this is a Linux/macOS consistency
fix for `getFile()`/`getDirectory()` mismatch, not a Windows polling fix.
The actual Windows silent polling failure needs further investigation — I'll
update the JIRA accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
