apupier opened a new pull request, #29227: URL: https://github.com/apache/camel/pull/29227
JettyHttpEndpointDisconnectTest asserted that the static JettyHttpComponent.CONNECTORS map was completely empty after context.stop(). That map is shared by the whole JVM and camel-jetty runs its tests in parallel, so a connector left behind by another test class could make this test fail even though its own connector was removed correctly (reported failure: "Connector should have been removed", expected 0 but was 1, on a port possibly not owned by this test). Only assert that the connector of this test (http:localhost:<port>) has been removed, and keep reporting its creation stack trace on failure. This is an attempt to stabilize the test and not a sure fix: the root cause of the leftover connector was not confirmed. If the failure was a real leak of this test's own connector, the assertion still catches it. Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
