UchihaIthachi opened a new pull request, #6933:
URL: https://github.com/apache/camel-k/pull/6933

   Fixes #6932
   
   Adds a KEDA scaler mapping for the `pulsar` component, following the 
`kafka.go` / `artemis.go` pattern.
   
   ### Mapping
   - `topic` <- endpoint path (`persistent://public/default/my-topic`)
   - `subscription` <- `subscriptionName`, else 
`camel.component.pulsar.subscription-name`, else `subs` (Camel's default)
   - `adminURL` <- host of `serviceUrl` / `camel.component.pulsar.service-url` 
on port 8080, since Camel has no admin URL option. It's only set for 
`pulsar://` URLs, so TLS setups (`pulsar+ssl://`) can still set `adminURL` 
through `keda.autoMetadata`.
   
   ### Tests
   - `pulsar_test.go`: registration, endpoint params, properties, precedence, 
defaults, TLS URL, plus a `MapToKedaTrigger` case
   - `e2e/keda/keda_pulsar_test.go`: Pulsar 4.0.4 standalone (Deployment + 
Service in the `keda` namespace, no operator). It checks the generated trigger 
metadata, then scales 1 -> 0, starts a producer, and checks 0 -> 1 -> 0
   - Docs: added `pulsar` to the auto-discovery list in `keda.adoc`
   
   Locally: unit tests pass, `make lint` reports 0 issues, the operator image 
builds, and the e2e package compiles with `-tags=integration`. I couldn't run 
the full e2e locally, only compile it. Pulsar standalone takes a while to 
start, so I gave its rollout 300s. If the KEDA job gets close to the 20m 
`test-keda` timeout, I can trim it.
   
   I used an AI assistant to help with parts of this change; I reviewed and 
tested every change locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to