gansheer opened a new pull request, #9432: URL: https://github.com/apache/camel-quarkus/pull/9432
Fixes #9421 `RuntimeBeanRepository#findByTypeWithName` dropped every CDI bean without `@Named` or `@Identifier` since #7559, so Camel's `DefaultConfigurationConfigurer` silently ignored SPI beans declared as plain CDI beans. A custom `UnitOfWorkFactory` is one example; the same applies to every SPI type resolved this way (`UuidGenerator`, `ShutdownStrategy`, ...). The filter was only there to avoid null map keys (#7558). This falls back to `InjectableBean#getIdentifier()` when a bean has no name, and keeps all available beans in the map, as before 3.26.0: * Unnamed beans are exposed again, keyed by their CDI bean identifier. * The identifier is a map key only, not a bean name, so `lookupByNameAndType` does not resolve a bean by it. **Behaviour change** A named and an unnamed bean of the same SPI type now produce two entries, and Camel's single-bean lookup installs neither. Previously the named bean was installed. This is documented in the 4.0.0 migration guide (`docs/modules/ROOT/pages/migration-guide/4.0.0.adoc`). **Testing** * `CamelUnnamedBeanTest` asserts that an unnamed `UnitOfWorkFactory` becomes the context plugin, that an unnamed bean is exposed by type, and that a named + unnamed pair of the same type is both visible through `findByTypeWithName`. All three tests fail without the runtime change. * Full `extensions-core/core/deployment` suite: 92 tests, 0 failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
