allthingssecurity commented on PR #29126:
URL: https://github.com/apache/camel/pull/29126#issuecomment-6625372562
Thanks @davsclaus, good catch, done in bfcfd5eb2b8f with your rule:
`splitArgumentsAsWritten` counts the depth only from a `${` on, so a bare `(`
or `{` in a text argument is text again, as on main. New checks in
`StringFunctionFactoryTest`: `substringBetween(${body},(,))` on `order (42)
done` gives `42`, `replace((,x)` replaces the `(` (it was refused by the first
version), and a nested `${header.s.substring(0,4)}` with its comma is still one
argument. The upgrade-guide sentence now only mentions the value lists of
`distinct`/`reverse`/`shuffle`/`list`/`map`, which still go through
`splitSafeQuote(..., true)`; I left those as they are, since `splitSafeQuote`
is shared, but I can move them to the same `${`-only rule in a follow-up if you
prefer. Local run: function factory tests, `SimpleTest` and the comma/edge-case
tests, 431, 0 failures.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
