oscerd opened a new pull request, #1864:
URL: https://github.com/apache/camel-kafka-connector/pull/1864
Fixes #1860.
### Problem
`camel.connector.dumpRoutes` (#1786, 4.22.0, default `true`) was passed to
Camel Main as `Boolean.toString(dumpRoutes)`. In Camel 4, `dumpRoutes` takes
the format of the dump, and `DefaultDumpRoutesStrategy.dumpRoutes(String)` only
acts on `yaml`, `xml` and `java`. As a result, nothing was dumped, either by
default or when the option was set explicitly.
### Change
- **Format.** `camel.connector.dumpRoutes=true` now sets the dump format to
`xml`. XML is the format every connector can write: core depends on
`camel-xml-jaxb`, while YAML would need `camel-yaml-io`.
- **Default.** The default is now `false`. Camel resolves property
placeholders in route dumps by default
(`camel.main.dumpRoutesResolvePlaceholders=true`), so a dump can contain
configuration values. Logging routes should therefore be an explicit choice,
and the option's doc says so. Nothing was ever dumped before, so users see no
difference.
- **Docs.** The option is added to both tables in
`basic-configuration.adoc`. It wasn't documented before.
### Tests
- `DumpRoutesTest` starts a source task:
- with `camel.connector.dumpRoutes=true`, it checks the context's dump
format and that `DefaultDumpRoutesStrategy` logs `Dumping ... routes as XML`
with the `<route` XML;
- with the default, it checks that nothing is dumped.
- `./mvnw -pl core -Psourcecheck install` runs 129 tests with 0 failures.
The full reactor build `./mvnw clean verify -DskipTests` succeeds.
_Claude Code on behalf of Andrea Cosentino_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
