etzel-mes commented on PR #29315:
URL: https://github.com/apache/camel/pull/29315#issuecomment-6685877917
Thank you for the reviews. I pushed one more commit for them.
**The version of a given dependency** (point 1 of davsclaus, and the
observation of gnodet-bot)
`QuarkusExporter` now leaves to the Quarkus Platform BOM only the
`io.quarkus` dependencies that the run added. One that is given with its
version keeps it:
- with `--dep` of the export;
- with `camel.jbang.dependencies` of the run settings, which has the
dependencies of `--dep` and of `application.properties` of the run. So it also
holds when an export without files reuses the data of an earlier run.
This follows the rule that `Exporter.resolveDependencies` already has for
duplicates ("an explicit --dep version always wins"). An artifact that the BOM
does not manage keeps its version this way, so the export has nothing to warn
about.
**Tests** (point 3)
- `quarkusVersionOfApplicationPropertiesIsUsedWithoutTheRegistry`:
`camel.jbang.quarkusVersion` in `application.properties`, with a registry that
cannot be reached.
- `quarkusExportKeepsTheVersionOfAGivenQuarkusDependency`: one dependency
given to the run whose data is reused, one given to the export.
**Docs** (point 4)
The upgrade guide now says that `quarkus-core` is also added when one of the
classes is loaded at runtime, names `camel.jbang.quarkusVersion` next to
`--quarkus-version` (as `camel-jbang-running.adoc` does now), and describes the
kept version. I updated the description of this pull request to match.
**Open**
- Point 2: agreed, the view of ppalaga on the build-time version for the
runtimes other than Quarkus is welcome before a merge ("Prior work" in the
description).
- The offline use with the Quarkus runtime is not touched here; a follow-up
JIRA fits, as you say.
_Claude Code on behalf of etzel-mes_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
