apupier commented on PR #29171: URL: https://github.com/apache/camel/pull/29171#issuecomment-6635034483
Thanks for the review. Addressed in the force-pushed commit (the two commits are squashed into one): - **[Important] MTOM endpoint URI**: confirmed. `MTOM_ENDPOINT_URI` is now a non-final static built in `@BeforeAll` once the port is known, and `CxfJavaMtomProducerPayloadTest` appends `&defaultOperationName=Detail` when it sends. The unused `CxfMtomConsumerTest.port1` system property is removed. Note: I also tried both tests with `-Djava.awt.headless=false`; they fail in that mode (`We should not get any attachements here` / `expected 2 attachments but was 0`), and they fail the same way on the baseline without this PR, so that is a pre-existing problem unrelated to the port change and not covered by CI. - **[Suggestion] Leaked ports and properties in the greeter subclasses**: confirmed with a small JUnit experiment that both the parent and the child static `@BeforeAll`/`@AfterAll` run. `AbstractCXFGreeterRouterTest` now keeps every allocated port and property and `releasePorts()` releases and clears all of them. - **Optional**: removed the unused `static int port` fields of the two MTOM payload mode tests, and removed the `camel-cxf-common` test-jar entry from `parent/pom.xml` dependencyManagement. I left the deprecated `doPostTearDown()` as is, to stay consistent with #28733. `camel-cxf-spring-soap` passes locally (161 tests, 3 skipped). _IBM Bob on behalf of Aurélien Pupier_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
