davsclaus commented on code in PR #29353:
URL: https://github.com/apache/camel/pull/29353#discussion_r4496448790
##########
dsl/camel-jbang/camel-jbang-run/src/main/java/org/apache/camel/dsl/jbang/run/export/SpringBootExporter.java:
##########
@@ -434,8 +439,8 @@ protected String getDockerfileTemplateName() {
}
@Override
- protected Set<String> resolveDependencies(Path settings, Path profile)
throws Exception {
- Set<String> answer = super.resolveDependencies(settings, profile);
+ protected Set<String> doResolveDependencies(Path settings, Path profile)
throws Exception {
Review Comment:
This method (line 448), and the `copySettingsAndProfile` callback at line
141, still detect the HTTP server with
`s.contains("mvn:org.apache.camel:camel-platform-http")`, so
`camel:platform-http` is missed. Please use `hasCamelArtifact(...,
"camel-platform-http") || hasCamelArtifact(..., "camel-platform-http-vertx")`
at both places. The review body has the details and a test idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
