TheNetherWatcher commented on PR #6913: URL: https://github.com/apache/camel-k/pull/6913#issuecomment-6709470795
> I think we should at least try to get the rabbitmq location by looking at the components properties like we are doing in artemis.go Done in 49c7ec5. The scaler now follows the connection factory referenced by `connectionFactory` (endpoint option or `camel.component.spring-rabbitmq.connection-factory`) and, if that bean is set up with `camel.beans.<name>.*` properties, builds `host` as `amqp://host:port/vhost` from its `uri`, `addresses` or `host`/`port`/`virtualHost`. Username and password are left out on purpose so they don't end up in the ScaledObject; those still go through a TriggerAuthentication or `keda.autoMetadata`. Unit tests and docs are updated. Also rebased on main and fixed the e2e: removed the duplicate `cloneAndReplaceNamespace` helper (main now has it in the pulsar test) and dropped the `replicas == 1` check right after Ready, which raced with KEDA scaling the idle consumer down to 0 and was why keda-test failed. The other failing jobs were the `mvnw --version` image build step, which isn't related to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
