allthingssecurity commented on PR #29406: URL: https://github.com/apache/camel/pull/29406#issuecomment-6718967075
Thanks Claus, you are right about the releases. Watermark tracking came in 4.22.0, and `Splitter.java` at `camel-4.22.0` (also 4.22.1 and 4.22.2), at `camel-4.23.0` and on `camel-4.22.x` has the same `wrapCallback` without try/finally and the same `persistWatermark` that caches before it stores. It is not on `camel-4.18.x` or `camel-4.14.x`. I corrected the description. Backport: agreed, since every later split on the route hangs. The code commit applies to `camel-4.22.x` without conflicts (checked with `git merge-tree`, not built yet). I'll open the backport PR once this one is merged, with a note in the 4.22 upgrade guide. Upgrade guide: I think a line is worth it, as the feature has been released. af5b540 adds an entry to the 4.24 guide: with `synchronous()`, a split whose store failed used to keep the watermark in memory, so the next split skipped those items; now it processes them again. Without `synchronous()` the exchange used to hang. The entry also says that a `watermarkExpression` that throws now fails its item, so `stopOnException`, `maxFailedRecords` and `errorThreshold` apply. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
