Dhairya-007 opened a new pull request, #29424:
URL: https://github.com/apache/camel/pull/29424

   Three options advertise a default value that the code does not use. In each 
case
   the `@UriParam` / `@Metadata` `defaultValue` disagrees with the field 
initialiser,
   and nothing else assigns the field, so the annotation — which is what feeds 
the
   component catalog, the reference docs and tooling completion — is the wrong 
half.
   
   | component | option | documented | actually used |
   | --- | --- | --- | --- |
   | camel-whatsapp | `webhookPath` | `webhook` | `camel-whatsapp/webhook` |
   | camel-zipfile | `fileSuffix` | `zip` | `.zip` |
   | camel-tarfile | `fileSuffix` | `tar` | `.tar` |
   
   **camel-whatsapp** — `WhatsAppConfiguration.webhookPath` is initialised to
   `camel-whatsapp/webhook`, and the only consumer
   (`WhatsAppEndpoint`, which copies it onto the webhook configuration) never
   substitutes anything else, so the documented `webhook` path is not one the
   component ever serves.
   
   **camel-zipfile / camel-tarfile** — the suffix is passed straight to
   `FileUtil.createTempFile(prefix, suffix, parentDir)`, which hands it to
   `Files.createTempFile` and appends it verbatim. The real default therefore 
yields
   `agg<random>.zip`, while a user who copies the documented `zip` loses the
   extension separator:
   
   ```
   $ java Suffix.java
   actual default  .zip -> agg14548409098255696663.zip
   actual default  .tar -> agg9194603237991251123.tar
   documented      zip  -> agg15585974513559476672zip
   documented      tar  -> agg11542269550683229435tar
   ```
   
   In every case the annotation is aligned with the behaviour rather than the 
other
   way round, so there is no functional change — only the advertised metadata 
moves.
   
   The last commit also fixes a copy-paste Javadoc: 
`TarAggregationStrategy.setFileSuffix`
   said "creating the ZIP filename".
   
   ### Generated files
   
   The regenerated `.json` files were edited by hand because the build cannot 
run in
   this environment. For each component I verified that the component/bean copy 
and
   the `camel-catalog` copy stay byte-identical afterwards (`diff -q`), and the
   `docs/.../examples/json/*.json` entries are symlinks that follow 
automatically.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to