allthingssecurity opened a new pull request, #29432: URL: https://github.com/apache/camel/pull/29432
# Description [CAMEL-26738](https://issues.apache.org/jira/browse/CAMEL-26738) The `JdbcKeyValueRepository` section of `keyValueRepository.adoc` said that `tableName` defaults to `camel_kvr` and showed an auto-created table with `kvr_key VARCHAR(255)` and `kvr_value TEXT`. The repository creates `CAMEL_KEYVALUE` (`DEFAULT_TABLENAME` and `DEFAULT_CREATE_STRING` in `JdbcKeyValueRepository`): ```sql CREATE TABLE CAMEL_KEYVALUE (ITEM_KEY VARCHAR(512) NOT NULL, ITEM_VALUE BLOB NOT NULL, EXPIRES_AT BIGINT NOT NULL DEFAULT 0, PRIMARY KEY (ITEM_KEY)) ``` A table created from the page could not be used by the repository. The same pages had the old `camel_kvr` name for the JPA and Cassandra repositories too. Change (docs only): - `keyValueRepository.adoc` (and its identical catalog copy): the default table name, the statement the code runs, what `ITEM_VALUE` and `EXPIRES_AT` hold, and that a database that does not accept that statement (no `BLOB` type, such as PostgreSQL) needs the table created by hand: with `tableName` set, all statements, `createString` included, are derived from the default ones, so a custom `createString` is only used without `tableName`. - `key-value-repository.adoc` (user manual): the JDBC example and the JPA section named `camel_kvr` as the default table; they now name `CAMEL_KEYVALUE`, which is also the table of the camel-jpa `KeyValueEntry` entity, and the TTL column is `EXPIRES_AT`. - The Cassandra sections of both pages named `camel_kvr` as the default table; `CassandraKeyValueRepository` uses `camel_keyvalue`. The user manual example called `setTableName`, which does not exist (the setter is `setTable`), and said that the table is created on startup, which the repository does not do. - The PostgreSQL example of the JDBC section uses `tableName`, so a sentence says its table must be created beforehand (with `BYTEA`). The example itself is unchanged, as #29405 changes its YAML block and the camel-jbang AI samples embed it. The camel-jbang AI samples (`eip-samples.json`) contain no changed block, so they are unchanged. This does not overlap with the lines #29405 changes in the same page. # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it): [CAMEL-26738](https://issues.apache.org/jira/browse/CAMEL-26738). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. (Docs only; the catalog copy of `keyValueRepository.adoc` is byte-identical to the source page. I did not run the full root build.) # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer. _Claude Code on behalf of allthingssecurity_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
