gnodet-bot commented on code in PR #29485:
URL: https://github.com/apache/camel/pull/29485#discussion_r4514058034
##########
components/camel-file/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
##########
@@ -146,13 +146,13 @@ public abstract class GenericFileEndpoint<T> extends
ScheduledPollEndpoint imple
+ "directory prefix: dir/finalFilename then tempFileName is relative to that
subdirectory dir.")
protected Expression tempFileName;
@UriParam(label = "producer,advanced", defaultValue = "true", description
= "Whether or not to eagerly delete "
-
+ "any existing target file. This option only applies when you use
fileExists=Override and the "
+
+ "any existing target file. This option only applies when you use
fileExist=Override and the "
+ "tempFileName option as well. You can use this to disable (set it to false)
deleting the target "
+ "file before the temp file is written. For example you may write big files
and want the target file "
+ "to exists during the temp file is being written. This ensure the target
file is only deleted until "
+ "the very last moment, just before the temp file is being renamed to the
target filename. This option "
+ "is also used to control whether to delete any existing files when
fileExist=Move is enabled, and an "
-
+ "existing file exists. If this option copyAndDeleteOnRenameFails false, then
an exception will be thrown "
+
+ "existing file exists. If this option is false, then an exception will be
thrown "
+ "if an existing file existed, if its true, then the existing file is deleted
before the move operation.")
Review Comment:
💡 Pre-existing grammar nit: `if its true` → `if it's true` (missing
apostrophe).
```suggestion
+ "if an existing file existed, if it's true, then the existing file is
deleted before the move operation.")
```
##########
components/camel-file/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
##########
@@ -146,13 +146,13 @@ public abstract class GenericFileEndpoint<T> extends
ScheduledPollEndpoint imple
+ "directory prefix: dir/finalFilename then tempFileName is relative to that
subdirectory dir.")
protected Expression tempFileName;
@UriParam(label = "producer,advanced", defaultValue = "true", description
= "Whether or not to eagerly delete "
-
+ "any existing target file. This option only applies when you use
fileExists=Override and the "
+
+ "any existing target file. This option only applies when you use
fileExist=Override and the "
+ "tempFileName option as well. You can use this to disable (set it to false)
deleting the target "
+ "file before the temp file is written. For example you may write big files
and want the target file "
+ "to exists during the temp file is being written. This ensure the target
file is only deleted until "
Review Comment:
💡 Pre-existing grammar nit: `to exists` → `to exist`.
```suggestion
+ "to exist during the temp file is being written. This ensure the target
file is only deleted until "
```
##########
components/camel-file/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
##########
@@ -1145,13 +1145,13 @@ public boolean isEagerDeleteTargetFile() {
/**
* Whether or not to eagerly delete any existing target file. This option
only applies when you use
- * fileExists=Override and the tempFileName option as well. You can use
this to disable (set it to false) deleting
+ * fileExist=Override and the tempFileName option as well. You can use
this to disable (set it to false) deleting
* the target file before the temp file is written. For example you may
write big files and want the target file to
* exists during the temp file is being written. This ensure the target
file is only deleted until the very last
* moment, just before the temp file is being renamed to the target
filename. This option is also used to control
* whether to delete any existing files when fileExist=Move is enabled,
and an existing file exists. If this option
- * copyAndDeleteOnRenameFails false, then an exception will be thrown if
an existing file existed, if its true, then
- * the existing file is deleted before the move operation.
+ * is false, then an exception will be thrown if an existing file existed,
if its true, then the existing file is
+ * deleted before the move operation.
Review Comment:
💡 Pre-existing grammar nit: `if its true` → `if it's true` (missing
apostrophe).
```suggestion
* is false, then an exception will be thrown if an existing file
existed, if it's true, then the existing file is
```
##########
components/camel-file/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
##########
@@ -1145,13 +1145,13 @@ public boolean isEagerDeleteTargetFile() {
/**
* Whether or not to eagerly delete any existing target file. This option
only applies when you use
- * fileExists=Override and the tempFileName option as well. You can use
this to disable (set it to false) deleting
+ * fileExist=Override and the tempFileName option as well. You can use
this to disable (set it to false) deleting
* the target file before the temp file is written. For example you may
write big files and want the target file to
* exists during the temp file is being written. This ensure the target
file is only deleted until the very last
* moment, just before the temp file is being renamed to the target
filename. This option is also used to control
Review Comment:
💡 Pre-existing grammar nit: `want the target file to\nexists` → `to exist`.
```suggestion
* the target file before the temp file is written. For example you may
write big files and want the target file to
* exist during the temp file is being written. This ensure the target
file is only deleted until the very last
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
