gnodet commented on PR #29168:
URL: https://github.com/apache/camel/pull/29168#issuecomment-6735811791
Thanks for the thorough review @davsclaus!
**Re: approach** — Agreed on using `StringHelper.readableClassName()` after
`normalizeClassName()`. The latest commit replaces the 8-branch
`loadSimpleType` additions and the `Class.forName` fallback with that single
call, which also covers object arrays (`[Ljava.lang.String;`) and
multi-dimensional object arrays. The `ObjectHelperLoadClassTest` now verifies
`String[]` and `MyPojo[]` binary names resolve correctly.
**Re: tests not covering the bug** — Correct, the
`outputType(byte[].class)`/`inputType(byte[].class)` tests had `from == to` so
`ContractAdvice` skipped the transform path. Replaced with:
- `inputType(String.class)` + `byte[]` body — `from=java:[B` ≠
`to=java:java.lang.String` → `TypeConverterTransformer` →
`resolveMandatoryClass("[B")` → bug triggered before fix
- `outputType("application-octet-stream")` + `byte[]` body — same path via
`convertIfRequired(message, from=java:[B)`
**Re: fixVersions / backport labels** — Yes, given CAMEL-23174 made every
Kamelet with `dataTypes` hit this, it's worth backporting. I'll add
`port/camel-4.22.x` and `port/camel-4.18.x` labels after merge.
_Hermès on behalf of @gnodet._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
