gnodet-bot commented on code in PR #29300:
URL: https://github.com/apache/camel/pull/29300#discussion_r4511070493
##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConstants.java:
##########
@@ -70,4 +70,7 @@ public interface GrpcConstants {
*/
String GRPC_BINDABLE_SERVICE_FACTORY_NAME = "grpcBindableServiceFactory";
String GRPC_RESPONSE_OBSERVER = "grpcResponseObserver";
+ String GRPC_RESPONSE_TYPE = "grpcResponseType";
Review Comment:
**Three new constants with no consumers on 4.22.x.**
`GRPC_RESPONSE_TYPE`, `GRPC_MUTE_EXCEPTION`, and
`GRPC_RESPONSE_OBSERVER_FAILED` are set via `setRouteControlledProperties()`
but `GrpcProducerToRouteControlledStreamObserver` on 4.22.x only reads the
pre-existing `GRPC_RESPONSE_OBSERVER`. These three constants are dead public
API on this branch. Consider omitting them from the backport until the
consuming code is also backported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
