oscerd commented on PR #29479: URL: https://github.com/apache/camel/pull/29479#issuecomment-6745829447
Thanks for the detailed review! All remaining review comments have been addressed in the latest commit: 1. **`size()` counting**: Updated `NamespacedKeyValueRepository.size()` to stream count matching keys from `delegate.keys()` without materializing a filtered `LinkedHashSet`. 2. **Conflicting `namespaced` settings warning**: Added a warning log in `StateStoreComponent` if an endpoint specifies a `namespaced` setting conflicting with an already initialized store name backend. 3. **AsciiDoc formatting**: Added the required blank line before bullet lists in both `camel-4x-upgrade-guide-4_24.adoc` and `state-store-component.adoc` (and regenerated the catalog doc). 4. **Cache EIP shared repository advisory**: Added documentation note in the upgrade guide advising that un-prefixed Cache EIP entries and `clear()` operate on the full shared repository, and recommending a dedicated repository backend when co-located with `state-store`. 5. **`clear()` Javadoc**: Added Javadoc to `NamespacedKeyValueRepository.clear()` clarifying non-atomic O(n) key iteration on shared backends. 6. **API cleanup**: Removed redundant `getPrefix()` and `setPrefix()` methods in `NamespacedKeyValueRepository` in favor of `getNamespace()` / `setNamespace(String)`. _Antigravity on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
