gnodet commented on PR #29153: URL: https://github.com/apache/camel/pull/29153#issuecomment-6737084376
Thanks @davsclaus for the follow-up review! The three doc issues you raised in your Nov 9 review are already addressed in commit `0f83b7d` (pushed ~55 minutes before your review, so we may have crossed): 1. **camel-jbang-debugging.adoc:85-87** — The text now correctly describes `runBackgroundProcess` semantics: "waits up to `--background-wait` (60 seconds by default) for the integration to start. It exits with `0` once the integration is running, with the integration's exit code when it fails to start, and with `124` when it is still starting at the end of the wait." No "detaches immediately" or "exits 0" without qualification. 2. **camel-4x-upgrade-guide-4_24.adoc:1848** — The line says ```camel debug --background` does not require an interactive terminal.``` — no "detaches immediately". 3. **camel-jbang-exit-codes.adoc:146** — Already has "except with `--background`": _"A command that only works in a terminal, such as `camel debug` (except with `--background`), `camel shell` or `camel tui`, exits with `2`."`_ Re: how a backgrounded debug session is driven — the background section ends with: _"Once the integration is running in the background with the route debugger enabled, you can attach to it from an interactive terminal with `camel debug --remote-attach <name>`."_ This covers the attach path. If you think more detail is warranted (e.g. that `--background` without specific `--breakpoint` will suspend at every step), I am happy to add a note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
