davsclaus commented on PR #29430: URL: https://github.com/apache/camel/pull/29430#issuecomment-6735626686
@oscerd thanks for the review. On the design point: the fluent tree is already step -> circuit breaker, not step -> `OnFallbackDefinition`. `OnFallbackDefinition.addOutput` (line 138) does `output.setParent(getParent())`, and `onFallback()` has set that parent to the circuit breaker (`CircuitBreakerDefinition.java:260`). So `adoptFallback()` gives a loaded route exactly the tree the fluent API builds, and anything walking parents sees the same nesting in both. `output.setParent(onFallback)` would make the loaded tree differ from the fluent one. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
