davsclaus commented on code in PR #29495:
URL: https://github.com/apache/camel/pull/29495#discussion_r4518306703
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MemoryTab.java:
##########
@@ -325,6 +334,16 @@ private void renderSparkline(Frame frame, Rect area,
IntegrationInfo info) {
}
}
+ if (axisW > 0) {
+ Style axis = Style.EMPTY.dim();
+ buf.setString(box.x(), inner.y(), top, axis);
+ if (chartH >= 5) {
+ String half = formatBytes(ceiling / 2);
+ buf.setString(box.x() + axisW - 1 - half.length(), inner.y() +
chartH / 2, half, axis);
Review Comment:
Fixed in dbde3a2678aa, slightly differently: the axis is as wide as its
widest label, so `512M` is shown in full instead of left out, and `1G` is
right-aligned above it. A test covers the 1G heap.
_Claude Code on behalf of davsclaus_
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TimelineTab.java:
##########
@@ -853,6 +856,11 @@ static List<Line> stacked(List<long[]> series, List<Style>
styles, int rows, int
}
/** A sparkline of values (-1 is unknown, blank), relative to the highest.
*/
+ /** The height of the mean time sparkline: twice the average or the
slowest second, at least 10 ms. */
Review Comment:
Fixed in dbde3a2678aa: `spark()` has its javadoc back and `meanScale()`
keeps its own.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
