gnodet-bot commented on PR #29523:
URL: https://github.com/apache/camel/pull/29523#issuecomment-6754348859
Two low-severity notes:
**`fileName()` headers check scans values, not just keys**
(`ChaosExperimentRun.java`):
`feed.headers().toLowerCase(Locale.ROOT).contains("camelfilename")` matches
anywhere in the header string — a value like `X-Source=camelfilename-processor`
would falsely suppress auto-naming. Checking only the key portion (before `=`
on each `\n`-separated line) is more robust. Negligible risk in a chaos
experiment context, but easy to fix.
**Wildcard endpoint guard** (`ChaosExperimentRun.java` line ~188): the new
`!feed.endpoint().endsWith("*")` condition also affects HTTP feed lookups (not
just file routes). Previously, a wildcard endpoint could resolve to a route
object; now it silently gets `null`. A one-line comment explaining the intent
("wildcards can't map to a single route for file-feed detection") would help
future readers.
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
