gnodet-bot commented on code in PR #29534:
URL: https://github.com/apache/camel/pull/29534#discussion_r4520327799
##########
core/camel-support/src/main/java/org/apache/camel/support/KeyValueRepositoryHelper.java:
##########
@@ -170,6 +171,25 @@ public static Object deserialize(ByteBuffer buffer, String
deserializationFilter
return deserialize(bytes, deserializationFilter);
}
+ /**
+ * Returns the time, in milliseconds since the epoch, at which an entry
stored now with the given time-to-live
+ * expires. When that time is beyond {@link Long#MAX_VALUE} (a
time-to-live of about {@link Long#MAX_VALUE}
+ * milliseconds or more), {@link Long#MAX_VALUE} is returned, so the entry
does not expire.
+ * <p/>
+ * The caller handles a {@code null}, zero or negative time-to-live (no
expiration) itself.
+ *
+ * @param ttl a positive time-to-live
+ * @return the expiration time in milliseconds since the epoch, at
most {@link Long#MAX_VALUE}
+ */
Review Comment:
💡 **New public method missing `@since` tag.**
`expiresAt(Duration)` is introduced in 4.24. Add a `@since` tag to its
Javadoc:
```suggestion
* @return the expiration time in milliseconds since the epoch, at
most {@link Long#MAX_VALUE}
* @since 4.24
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
